arkorty/DownLink
1
0
Fork 0
mirror of https://github.com/arkorty/DownLink.git synced 2026-03-17 16:51:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Simplify the quality matching logic

Browse Source
This commit is contained in:
Arkaprabha Chakraborty
2024-08-12 23:11:40 +05:30
parent 6ffcbaa221
commit 6bab533721
1 changed files with 3 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
backend/main.go
View File

@@ -7,7 +7,6 @@ import (
"os" "os"
"os/exec" "os/exec"
"path/filepath" "path/filepath"
"strings"
"github.com/labstack/echo" "github.com/labstack/echo"
"github.com/labstack/echo/middleware" "github.com/labstack/echo/middleware"
@@ -20,47 +19,6 @@ type VideoDownloadRequest struct {
Quality string `json:"quality"` Quality string `json:"quality"`
} }
// getBestFormat fetches and returns the best format for the given quality
func getBestFormats(url string, targetResolution string) (string, string, error) {
log.Printf("Getting best formats for URL: %s, target resolution: %s", url, targetResolution)
cmd := exec.Command("./venv/bin/python3", "-m", "yt_dlp", "--cookies", "cookies.txt", "--list-formats", url)
output, err := cmd.CombinedOutput()
if err != nil {
return "", "", fmt.Errorf("failed to list formats: %v\nOutput: %s", err, string(output))
}
lines := strings.Split(strings.TrimSpace(string(output)), "\n")
var bestVideoFormat, bestAudioFormat string
targetHeight := strings.TrimSuffix(targetResolution, "p")
for _, line := range lines {
fields := strings.Fields(line)
if len(fields) < 3 {
continue
}
if strings.Contains(line, targetHeight) && strings.Contains(line, "mp4") && bestVideoFormat == "" {
bestVideoFormat = fields[0]
}
if strings.Contains(line, "audio only") && strings.Contains(line, "m4a") && bestAudioFormat == "" {
bestAudioFormat = fields[0]
}
if bestVideoFormat != "" && bestAudioFormat != "" {
break
}
}
if bestVideoFormat == "" || bestAudioFormat == "" {
return "", "", fmt.Errorf("no suitable formats found for resolution: %s", targetResolution)
}
log.Printf("Selected video format: %s, audio format: %s", bestVideoFormat, bestAudioFormat)
return bestVideoFormat, bestAudioFormat, nil
}
func downloadVideo(c echo.Context) error { func downloadVideo(c echo.Context) error {
req := new(VideoDownloadRequest) req := new(VideoDownloadRequest)
if err := c.Bind(req); err != nil { if err := c.Bind(req); err != nil {
@@ -70,12 +28,6 @@ func downloadVideo(c echo.Context) error {
return echo.NewHTTPError(http.StatusBadRequest, "URL and Quality are required") return echo.NewHTTPError(http.StatusBadRequest, "URL and Quality are required")
} }
// Get the best video and audio formats
videoFormat, audioFormat, err := getBestFormats(req.URL, req.Quality)
if err != nil {
return echo.NewHTTPError(http.StatusInternalServerError, fmt.Sprintf("Failed to get best formats: %v", err))
}
// Create a temporary directory for downloading files // Create a temporary directory for downloading files
tmpDir, err := os.MkdirTemp("", "downlink") tmpDir, err := os.MkdirTemp("", "downlink")
if err != nil { if err != nil {
@@ -91,8 +43,9 @@ func downloadVideo(c echo.Context) error {
outputPath := filepath.Join(tmpDir, fmt.Sprintf("output_%s.mp4", uid)) outputPath := filepath.Join(tmpDir, fmt.Sprintf("output_%s.mp4", uid))
// Download video and audio combined // Download video and audio combined
combinedFormat := fmt.Sprintf("%s+%s", videoFormat, audioFormat) quality := req.Quality[:len(req.Quality) - 1]
cmdDownload := exec.Command("./venv/bin/python3", "-m", "yt_dlp", "--cookies", "cookies.txt", "-f", combinedFormat, "-o", outputPath, req.URL) mergedFormat := fmt.Sprintf("bestvideo[height<=%s]+bestaudio/best[height<=%s]", quality, quality)
cmdDownload := exec.Command("./venv/bin/python3", "-m", "yt_dlp", "--cookies", "cookies.txt", "-f", mergedFormat, "--merge-output-format", "mp4", "-o", outputPath, req.URL)
if err := cmdDownload.Run(); err != nil { if err := cmdDownload.Run(); err != nil {
return echo.NewHTTPError(http.StatusInternalServerError, fmt.Sprintf("Failed to download video and audio: %v", err)) return echo.NewHTTPError(http.StatusInternalServerError, fmt.Sprintf("Failed to download video and audio: %v", err))
} }